From 21ff78924d2c97dac45e2dc7aef56bf3fb22f9b9 Mon Sep 17 00:00:00 2001 From: Caleb Maclennan Date: Sat, 23 Dec 2023 18:32:23 +0300 Subject: [PATCH] test(core): Mark output of ICU 74 as unsupported for expectations --- tests/sura-2.sil | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tests/sura-2.sil b/tests/sura-2.sil index f077563a4..154bafb93 100644 --- a/tests/sura-2.sil +++ b/tests/sura-2.sil @@ -1,4 +1,17 @@ \begin[papersize=a6,direction=RTL]{document} +\begin{lua} + -- ICU 74 introduced a change that affects where SILE sees font + -- property changes in this text. Both outputs are fine, but we + -- don't have tooling to expect different outputs for the same + -- inputs yet, so this work around just allows this test to fail + -- on ICU 74. As of this commit our CI system uses ICU 70, so + -- only some local developer testing is affected. When CI ever + -- starts breaking we might make that the expectation and mark it + -- unsupported on other versions. + local icu = require("justenoughicu") + local icu74plus = tostring(icu.version()) >= "74.0" + if icu74plus then SILE.status.unsupported = true end +\end{lua} \nofolios \font[family=Amiri Quran,size=20pt] \use[module=packages.linespacing]