Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a invoice_ready signal #624

Open
bogdanpetrea opened this issue Nov 16, 2018 · 0 comments
Open

Add a invoice_ready signal #624

bogdanpetrea opened this issue Nov 16, 2018 · 0 comments

Comments

@bogdanpetrea
Copy link
Contributor

If somebody wants to send emails when an invoice is issued for example, and wants to attach the PDF file to the invoice, it will have to render it on the spot (since it is rendered async and it's not ready when the invoice transitioned signal is triggered). That might take a long time (because of xhtml2pdf), and if it happens during a web request, it might throw a timeout error, resulting in the transaction not updating it's status etc.

A solution would be to create a signal called invoice_ready (state=[issued, paid...]), and send it when the PDF is done rendering after an invoice transition. Similar for proformas. This signal should state that the document is ready to be shown to the customer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant