Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: investigate how to improve highlighting #56

Open
AgustinSilverfin opened this issue Feb 12, 2024 · 2 comments
Open

Feature request: investigate how to improve highlighting #56

AgustinSilverfin opened this issue Feb 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@AgustinSilverfin
Copy link
Contributor

AgustinSilverfin commented Feb 12, 2024

Is your feature request related to a problem? Please describe.
We want to improve highlighting of liquid in VSCode, including if possible Silverfin flavored liquid elements. We still need to investigate what is the best way to approach it.

Describe the solution you'd like
Every element in the code is highlighted properly. For example, custom drops: custom.foo.bar where namespace and key should be highlighted properly

Describe alternatives you've considered

@AgustinSilverfin AgustinSilverfin added the enhancement New feature or request label Feb 12, 2024
@AgustinSilverfin
Copy link
Contributor Author

I've been playing around with tree-sitter, basically cloning Shopify's repo and trying to extend it. So I wrote the grammar rules for translations tags and I think I got something really interesting! This is how the tree of a liquid file looks and the items identified in translations (notice the highlighting on top of the translation key)

image

Picked up translations because I though it could be useful to address #54, but also could be done with parts and shared parts for #55 and so on!

@AgustinSilverfin
Copy link
Contributor Author

Include tags to identify parts and shared parts
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant