Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line number gutter blocking selection bar #333

Open
jbromberg opened this issue Jan 17, 2024 · 2 comments
Open

Line number gutter blocking selection bar #333

jbromberg opened this issue Jan 17, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jbromberg
Copy link

What happened?

This is sort of a nitpick, but when selected on text that is next to the line number, the selection bar is clipped. It would be great if the selection bar was rendered above the line number gutter.
IMG_46AB3CC9E51F-1

What are the steps to reproduce?

Select text next to line number gutter

What is the expected behavior?

Selection bar renders on top of the line number gutter

@jbromberg jbromberg added the bug Something isn't working label Jan 17, 2024
@simonbs
Copy link
Owner

simonbs commented Jan 21, 2024

Thanks for opening the issue. I’ll see if there’s a good way to address this in a future update to Runestone.

Selection bars are also shown below the navigation bar, even when a UITextView is scrolled to the top, so I don’t consider this a critical issue. At the time being, it can be worked around by increasing the textContainerInset.

I’m working on a big update to the framework and will consider good ways to fix it as part of that update.

@jbromberg
Copy link
Author

Awesome thanks. I've just started using Runestone and it's been great. Looking forward to the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants