Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to find address immediate #169

Open
RappyPhan opened this issue Aug 18, 2024 · 5 comments
Open

failed to find address immediate #169

RappyPhan opened this issue Aug 18, 2024 · 5 comments

Comments

@RappyPhan
Copy link

I created a scratch on decomp.me targeting x86 Windows: https://decomp.me/scratch/dhRdk

As you can see, it's empty, save for a message in the Problems pane:

Diff error: Error running asm-differ: failed to find address immediate for line 'mov %eax,0(%ebp)'

@1superchip
Copy link
Contributor

It looks like the regexes in process_reloc aren't capturing 0/0x0 in this instruction. But ebp shouldn't have a relocation though, as it is a copy of the stack pointer?

The immediate being 0 instead of 0x0 is related to #160

@ivanka2012
Copy link

ivanka2012 commented Sep 8, 2024

Well, for me the 0x is not stripped

Diff error: Error running asm-differ: failed to find address immediate for line 'mov %eax,0x0(,%edx,4)'

@ivanka2012
Copy link

Changing this regex seems to work on first sight, but I'm pretty sure this is a giant mistake:
(^\$?|(?<=\*))0x0 -> (^\$?|(?<=\*)|)0x0

@ivanka2012
Copy link

ivanka2012 commented Dec 10, 2024

Another one:
Diff error: Error running asm-differ: failed to find address immediate for line 'movss %xmm0,0x4'
The 0x4 is from the compiled object file and it's an offset to a global variable, like this:
movss %xmm0, _vBestNormal+4
This time the following hack works:
(^|(?<=\*)|(?<=\$))0x[0-9a-f]+ -> (^|(?<=\*)|(?<=\$)|(?<=,))0x[0-9a-f]+

@MrSapps
Copy link

MrSapps commented Jan 30, 2025

Seen here too https://decomp.me/scratch/XlGeq

Diff error: Error running asm-differ: failed to find address immediate for line 'mov %eax,4'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants