Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make asm-differ more resilient to parsing errors #179

Open
ethteck opened this issue Feb 2, 2025 · 0 comments
Open

Make asm-differ more resilient to parsing errors #179

ethteck opened this issue Feb 2, 2025 · 0 comments

Comments

@ethteck
Copy link
Contributor

ethteck commented Feb 2, 2025

I'm not sure how feasible it even is, but it'd be cool to have asm-differ bail on individual lines it can't handle and just fall back to some un-parsed representation, rather than totally error out

From @simonlindholm:

yes, making asm-differ more resilient would be fantastic
make it try-except the processing of every line, and do something smart in the except handler that effectively just emits a single error line

example failure: https://decomp.me/scratch/XlGeq

Requested originally by @MrSapps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant