x86 relocation applied incorrectly

[1superchip]

It looks like a regex is capturing the wrong data in the instruction fstps 0x10. We should be getting ?lastCollision@@3UCollisionResult@@A+0x10.

The regex is capturing 0 at the end of 0x10 and then replacing that with the relocation.

asm-differ output:

objdump:

Scratch: https://decomp.me/scratch/5IHQ5

Looking at the regexes within process_reloc, we are getting a bad result with https://github.com/simonlindholm/asm-differ/blob/main/diff.py#L2079C36-L2079C46. https://regex101.com/r/SUIY2l/1

This looks similar to the issue of #183 (comment).

[1superchip]

The regex (?:0x)?(?<![1-9])0$ looks good.

It doesn't match any strings that have 1-9 before the final 0.

https://regex101.com/r/rH4Vp2/1