Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCs not detected for processing #358

Open
kkappler opened this issue Sep 28, 2024 · 0 comments
Open

FCs not detected for processing #358

kkappler opened this issue Sep 28, 2024 · 0 comments

Comments

@kkappler
Copy link
Collaborator

kkappler commented Sep 28, 2024

Since the KernelDataset moved to mtpy, FCs are not being used for processing when present.

  • Note that the fc column also defaults to False ... it should default to None, as we do not know if fcs are there until we have a processing config ... we may wish to remove it entirely in fact.
  • In fact the presence of fcs, at least until now, was only relevant when fcs were used for processing. That column may want to go into processing summary.
    ...
    In any case, I am able to restore the desired behaviour by this PR in mtpy.

If that is no-go, then comment out the if statement around L168 in /aurora/pipelines/transfer_function_kernel.py

    def all_fcs_already_exist(self) -> bool:
        """Return true of all FCs needed to process data already exist in the mth5s"""
        if self.kernel_dataset.df["fc"].isna().any():
            self.check_if_fcs_already_exist()

        # these should all be booleans now
        assert not self.kernel_dataset.df["fc"].isna().any()

        return self.kernel_dataset.df.fc.all()
kkappler added a commit that referenced this issue Oct 1, 2024
- towards #358 (it is fixed but needs a test)
- adding some tools in test_processing (_make_processing_config_and_kernel_dataset)
  to use for test in test_fourier_coefficients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant