Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: metadata/metarefresh error handling improvements #1

Open
grawity opened this issue May 10, 2018 · 3 comments
Open

RFE: metadata/metarefresh error handling improvements #1

grawity opened this issue May 10, 2018 · 3 comments

Comments

@grawity
Copy link

grawity commented May 10, 2018

Currently the eduGAIN feed contains an SP with empty <mdui:Logo>. When running Metarefresh, this makes mdui\Logo throw an exception, saying Missing url value for Logo. Now that's okay, although it doesn't tell me anything about which entity it is.

But 1) the exception propagates all the way upwards, cancelling the import of the entire feed – meaning that just about any SP anywhere can accidentally break my whole eduGAIN access. (Somehow even eduGAIN didn't catch this error.) Maybe it would be possible to skip just that one entity – or even load it without any logos, as they're probably not crucial to the operation.

And 2) the exception is eventually swallowed and thrown away in MetaLoader, which instead shows a very generic "XML parser error when parsing https://fedi.litnet.lt/metadata/edugain.xml - attempting to re-use cached metadata". I spent quite some time trying to figure out that one, as the file is perfectly valid XML. I think it would be good to show the actual exception that was caught.

@grawity grawity closed this as completed May 21, 2018
@tvdijen

This comment has been minimized.

@grawity

This comment has been minimized.

@grawity grawity reopened this May 21, 2018
@thijskh
Copy link
Member

thijskh commented Nov 21, 2018

This is definitely something for which PR's are welcome.

@tvdijen tvdijen transferred this issue from simplesamlphp/simplesamlphp Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants