Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using ProcessingChain for authproc processing #179

Open
pradtke opened this issue May 3, 2022 · 3 comments
Open

Consider using ProcessingChain for authproc processing #179

pradtke opened this issue May 3, 2022 · 3 comments

Comments

@pradtke
Copy link
Collaborator

pradtke commented May 3, 2022

Our authproc processing in AuthProcService->processState() is missing some features from the main ProcessingChain. If an authproc needs to redirect the user somewhere (for consent, mfa, etc) then there is no easy way to resume the processing from the next filter. The ProcessingChain class used by SSP allows for resuming by storing the not-yet processed filter in the $state.

I think wrapping ProcessingChain from AuthProcService would allow us to use authproc filters that perform redirects.

@restena-sw
Copy link

I also have a use case for an interactive authproc (MFA with the simplesamlphp-module-webauthn). Being able to run interactive authprocs would be a very valuable addition.

@pradtke
Copy link
Collaborator Author

pradtke commented Apr 24, 2024

When I did similar work for the authoauth2 module it was not as complicated as I was expecting. Most of that PR is documentation and testing, and maybe a dozen lines for the authproc method.

@pradtke
Copy link
Collaborator Author

pradtke commented Jul 11, 2024

Should be part of the next major release. Functionality merged in #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants