Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package split missing #547

Open
mdartic opened this issue Nov 29, 2024 · 0 comments
Open

Package split missing #547

mdartic opened this issue Nov 29, 2024 · 0 comments

Comments

@mdartic
Copy link

mdartic commented Nov 29, 2024

When using the latest version of surge, after install with a npm install surge

and a deploy with a

$ npx surge dist ***.surge.sh

an error appear :

node:internal/modules/cjs/loader:1228
  throw err;
  ^
Error: Cannot find module 'split'
Require stack:
- ***/node_modules/surge/lib/middleware/ssl.js
- ***/node_modules/surge/lib/surge.js
- ***/node_modules/surge/bin/surge
    at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (***/node_modules/surge/lib/middleware/ssl.js:7:19)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '***/node_modules/surge/lib/middleware/ssl.js',
    '***/node_modules/surge/lib/surge.js',
    '***/node_modules/surge/bin/surge'
  ]
}
Node.js v20.18.1

Indeed, the package split is required in lib/middleware/ssl.js here https://github.com/sintaxi/surge/blob/master/lib/middleware/ssl.js#L7.

If I install it through a npm install split, surge works again.

It seems this package is removed here.

I don't know if I'm the only concerned, as it is a commit "old" (august, 6th), but, well...

If needed, I can propose a PR with the split package added to the package.json + package-lock.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant