Fixed string truncation for TestReport's comment #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django's
Truncator(text).chars(n)
seems to ignore all unicode combining characters, resulting in incorrect string truncations.For example,
this outputs:
If we were to remove the unicode symbol, it would correctly output 20. Whether this is truly intended or not eludes me.
When trying to put a string truncated in such manner into a CharField, it fails to pass the MaxLengthValidator check, as it internally uses len() for its check.
Since Python 3, strings respect Unicode by default, so slices seem to work fine for truncation.