From ea6fdcbd8cb6cf1d329f46aded6e3f8359a1fcfb Mon Sep 17 00:00:00 2001 From: Donat Zenichev Date: Fri, 27 Sep 2024 09:15:47 +0200 Subject: [PATCH] MT#61140 Fix Coverity Scan defect (to_tag_flag) Add `break` statement. Fixes: *** CID 1600019: Control flow issues (MISSING_BREAK) /daemon/call_interfaces.c: 1162 in call_ng_flags_flags() 1156 out->strip_extmap = 1; 1157 break; 1158 case CSH_LOOKUP("symmetric-codecs"): 1159 ilog(LOG_INFO, "Ignoring obsolete flag `symmetric-codecs`"); 1160 break; 1161 case CSH_LOOKUP("to-tag"): >>> CID 1600019: Control flow issues (MISSING_BREAK) >>> The case for value "155" is not terminated by a "break" statement. 1162 case CSH_LOOKUP("to_tag"): 1163 /* including the To tag in the delete message allows to be more selective 1164 * about monologues within a dialog to be torn down. */ 1165 out->to_tag_flag = 1; 1166 case CSH_LOOKUP("trickle-ICE"): 1167 case CSH_LOOKUP("trickle-ice"): Change-Id: I0195341ec70ea623ea7fece3782cfdc030ee4eaf (cherry picked from commit ac4a1bab381c0239d2f3975dbb97e1029cffb169) (cherry picked from commit 442884c6ff461658a8571f15b18b6ce0873ea871) --- daemon/call_interfaces.c | 1 + 1 file changed, 1 insertion(+) diff --git a/daemon/call_interfaces.c b/daemon/call_interfaces.c index 556e2946a..fbee133f3 100644 --- a/daemon/call_interfaces.c +++ b/daemon/call_interfaces.c @@ -1194,6 +1194,7 @@ void call_ng_flags_flags(sdp_ng_flags *out, str *s, helper_arg dummy) { /* including the “To” tag in the “delete” message allows to be more selective * about monologues within a dialog to be torn down. */ out->to_tag_flag = 1; + break; case CSH_LOOKUP("trickle-ICE"): case CSH_LOOKUP("trickle-ice"): out->trickle_ice = 1;