Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temperature in "Temp" column isn't sufficient #65

Open
bernstei opened this issue Nov 29, 2022 · 2 comments
Open

temperature in "Temp" column isn't sufficient #65

bernstei opened this issue Nov 29, 2022 · 2 comments
Labels
documentation Documentation and comments

Comments

@bernstei
Copy link

I'm trying to run sportran-analysis with a table that has a column for temperature, one for volume, and 48 for flux components (xyz x 16 independent runs). I get the following error

> sportran-analysis --VOLUME 392737.783943168 -k flux -t 5 --input-format table -u metal -r --FSTAR 1 -c 2 --output TCEPS.out -- tmp2.txt
.
.
Traceback (most recent call last):
  File "/home/cluster2/bernstei/.local/bin/sportran-analysis", line 8, in <module>
    sys.exit(main())
  File "/home/cluster2/bernstei/.local/lib/python3.9/site-packages/sportran/analysis.py", line 210, in main
    run_analysis(args)
  File "/home/cluster2/bernstei/.local/lib/python3.9/site-packages/sportran/analysis.py", line 393, in run_analysis
    j = st.current.all_currents[current_type][0](currents, DT_FS=DT_FS, UNITS=units, **parameters,
  File "/home/cluster2/bernstei/.local/lib/python3.9/site-packages/sportran/current/current.py", line 58, in __init__
    raise ValueError('The input parameters {} must be defined.'.format(self._input_parameters - keyset))
ValueError: The input parameters {'TEMPERATURE'} must be defined.

I see where the "Temp" field is detected (analysis.py line 317), but I don't see where value is supposed to be inserted into the parameters dict before it's passed in line 393.

tmp2.txt

@bernstei
Copy link
Author

I see that the "Temp" column detection is only being done for lammps input format. Is there a reason it can't also be done for table?

@bernstei
Copy link
Author

I was able to get it to work (at least that part) by adding --param-from-input-file-column Temp TEMPERATURE --param-from-input-file-column Volume VOLUME, but I had expected (based on the --help output) that it'd work automatically if the columns had the expected names.

@rikigigi rikigigi added the documentation Documentation and comments label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation and comments
Projects
None yet
Development

No branches or pull requests

2 participants