Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete implementation for the move() function #192

Open
0xibs opened this issue Jan 11, 2025 · 19 comments · May be fixed by #195
Open

Complete implementation for the move() function #192

0xibs opened this issue Jan 11, 2025 · 19 comments · May be fixed by #195

Comments

@0xibs
Copy link
Collaborator

0xibs commented Jan 11, 2025

The move function is located at game_actions.cairo

ETA: 3 days (Please let me know if you need more time)

Description
The move() function has been implemented in the client already and can be found here. The scope of this issue is to translate the logic implemented in the client into Cairo(Dojo). Feel free to modify the Game model or add utility functions that can be called from the move function if necessary.

Expectations

  • Ensure the move function is working as described
  • Add tests to verify the function works as expected. Tests should also verify that edge cases are handled properly.
@greatest0fallt1me
Copy link

I have good knowledge in cairo, can this be assigned to me @princeibs ?

@Jagadeeshftw
Copy link
Contributor

I would like to work on this @princeibs ETA: 2 days

@1nonlypiece
Copy link

Hello @princeibs , I’d like to work on this issue as I have experience with Cairo and building on StarkNet, including writing and optimizing smart contracts.

ETA:
I estimate completing this task in about 24-48 hours. Let me know if I can get started!

@emarc99
Copy link
Contributor

emarc99 commented Jan 11, 2025

Can I give tackle this this?
ETA - 3days

@No-bodyq
Copy link

Hello @princeibs can I work on this

@0xibs 0xibs self-assigned this Jan 11, 2025
@Abeeujah
Copy link
Collaborator

Can I work on this?

@0xibs 0xibs assigned Abeeujah and unassigned 0xibs and Abeeujah Jan 11, 2025
@0xibs
Copy link
Collaborator Author

0xibs commented Jan 16, 2025

@Jagadeeshftw still interested in working on this?

@Jagadeeshftw
Copy link
Contributor

Jagadeeshftw commented Jan 16, 2025

Yes @0xibs, I'm still interested in working on this. ETA: 2 days

Copy link

co-lead bot commented Jan 16, 2025

Thank you @Jagadeeshftw for your interest in contributing to sivicstudio/starkludo. Endeavour to create a pull request before Sat, 18 Jan 2025 11:44:24 GMT so as not to get unassigned.

@0xibs
Copy link
Collaborator Author

0xibs commented Jan 16, 2025

@Jagadeeshftw the issue description has been updated. Don't hesitate to reach out if you have any questions.

Copy link

co-lead bot commented Jan 17, 2025

Hi @Jagadeeshftw. A quick reminder that 50% of the time allocated for this issue has passed since you were assigned. Please create a PR before Sat, 18 Jan 2025 11:44:24 GMT to avoid being unassigned.

Copy link

co-lead bot commented Jan 18, 2025

Hi @Jagadeeshftw. A quick reminder that 80% of the time allocated for this issue has passed since you were assigned. Please create a PR before Sat, 18 Jan 2025 11:44:24 GMT to avoid being unassigned.

@Jagadeeshftw
Copy link
Contributor

Hi 0xibs,

Need one more day to complete. I will raise a PR tomorrow.

Copy link

co-lead bot commented Jan 18, 2025

Hi @Jagadeeshftw, ETA for this issue has been updated to Sun, 19 Jan 2025 11:44:25 GMT). Create a pull request before the new ETA to avoid being unassigned.

Copy link

co-lead bot commented Jan 19, 2025

Hi @Jagadeeshftw. A quick reminder that 95% of the time allocated for this issue has passed since you were assigned. Please create a PR before Sun, 19 Jan 2025 11:44:25 GMT to avoid being unassigned.

@0xibs
Copy link
Collaborator Author

0xibs commented Jan 19, 2025

@Jagadeeshftw have you been able to make any progress with this?

@Jagadeeshftw
Copy link
Contributor

Yes @0xibs, I've completed around 80% of the work. I'll go ahead and raise a draft MR now.

@Jagadeeshftw
Copy link
Contributor

I will complete it by the end of today.

@0xibs
Copy link
Collaborator Author

0xibs commented Jan 19, 2025

I would love a draft pr @Jagadeeshftw

@Jagadeeshftw Jagadeeshftw linked a pull request Jan 19, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants