Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API RF: Improve the way nested relationships are stored #202

Open
ecoslado opened this issue Nov 3, 2016 · 6 comments
Open

API RF: Improve the way nested relationships are stored #202

ecoslado opened this issue Nov 3, 2016 · 6 comments

Comments

@ecoslado
Copy link
Contributor

ecoslado commented Nov 3, 2016

I've changed the API to implement JSON API Standard. I used ActiveModel Serializers to do that, but I didn't find the way to make the serializer to store nested relationships in objects. So, in commons_controller.rb, I add every relationship explicitly:
https://github.com/siwapp/siwapp/blob/master/app/controllers/api/v1/commons_controller.rb#L49

Look for a cleaner solution.

@dnwilson
Copy link

@ecoslado why not use Fast JSON Api?

@peillis
Copy link
Member

peillis commented Jul 18, 2019

That could be definitively a good option. Right now I'm working on upgrading to Rails 5, but after that this could be done.

@dnwilson
Copy link

@peillis I have a forked Rails 5.2 version in production

@peillis
Copy link
Member

peillis commented Jul 19, 2019

Great! but where is the code? I can't see any of it in your account.

@dnwilson
Copy link

I made it private because I added additional ERP functionality and commit confidential information by accident but I'll make a PR for the 5.2 portion of the upgrade

@peillis
Copy link
Member

peillis commented Jul 19, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants