Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MakeDenseMatrix generates garbage #1

Open
soniakeys opened this issue Jun 27, 2012 · 1 comment
Open

MakeDenseMatrix generates garbage #1

soniakeys opened this issue Jun 27, 2012 · 1 comment

Comments

@soniakeys
Copy link

MakeDenseMatrix makes a new slice for A.elements, then loses it to the garbage collector by assigning the parameter elements. The intent isn't documented and seems ambiguous from the code. Maybe the make should be deleted, or maybe data should be copied from the parameter.

@skelterjohn
Copy link
Owner

Definitely a bug. My intention is reflected in the behavior of the code, and the unused-yet-allocated memory needs to go. I'll take care of it when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants