Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry and related logic to the SDK v2 #7

Closed
ja6a opened this issue Oct 17, 2018 · 3 comments
Closed

Add retry and related logic to the SDK v2 #7

ja6a opened this issue Oct 17, 2018 · 3 comments
Assignees
@ja6a

Comments

@ja6a
Copy link

ja6a commented Oct 17, 2018

see api/api.go and api/requests.go in the original SDK for context.

Originally posted by @jchenry in #5 (comment)
@ja6a ja6a changed the title I notice there is no retry logic in the client, and only DefaultHTTPClient is used. Skytap has specific semantics around resources being busy, and even though a resource may be busy when trying to update, this is not considered a failure. Add retry and related logic to the SDK v2 Oct 17, 2018
@ja6a
Copy link
Author

ja6a commented Oct 17, 2018

Please refer to issue #16 of the skytap/terraform-provider-skytap project.

@ja6a ja6a mentioned this issue Oct 17, 2018
Merged
@ja6a
Copy link
Author

ja6a commented Jan 7, 2019

#27 adds specific retry logic to the vm create method.
#11 adds general retry logic to the requests.

@ja6a ja6a self-assigned this Jan 7, 2019
@ja6a
Copy link
Author

ja6a commented Jun 28, 2019

This has been addressed under PR #42

@ja6a ja6a closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ja6a ja6a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ja6a