Skip to content
This repository has been archived by the owner on Aug 15, 2022. It is now read-only.

Allow Advanced Logging Configuration #66

Open
4 tasks done
ericparton opened this issue Dec 5, 2016 · 3 comments
Open
4 tasks done

Allow Advanced Logging Configuration #66

ericparton opened this issue Dec 5, 2016 · 3 comments

Comments

@ericparton
Copy link

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Description

Currently, all logging is done to the file specified by LOGFILE, which is configurable. It would be useful to allow more advanced logging configurations via python logging configuration files, as shown here in the python documentation.

Reproducible in:

  • This is reproducible in the sample project.
    RTMBot version: 0.4.0
    Python version: 2.7.11
    OS Version: All
@onlyanegg
Copy link

+1
It would be nice to have access to a logger within plugins.

@pbdabholkar
Copy link

@onlyanegg we can use python logging to log lines something like the following. You have to just import logging at the top of your python script.

logging.info("Got {} Records".format(len(records)))

And you can get the following log entry

2018-04-17 17:58:03,001 Got 2 Records

@Roach
Copy link
Contributor

Roach commented May 29, 2018

This library could use a lot more debug and other logging. I'd prefer it to inherit the app's default logger than implement a logger specific to this package. I've also been adding logging to the underlying slackclient library which will enable more logging within rtmbot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants