From d859fd016c7866694adf59a9ac07a8be2fa099e5 Mon Sep 17 00:00:00 2001 From: Henry Robinson Date: Wed, 10 Apr 2024 13:05:38 +0100 Subject: [PATCH] Comment Signed-off-by: Henry Robinson --- go/vt/vtgateproxy/vtgateproxy.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/go/vt/vtgateproxy/vtgateproxy.go b/go/vt/vtgateproxy/vtgateproxy.go index 5cd0c1d44ea..8a30dd5efa8 100644 --- a/go/vt/vtgateproxy/vtgateproxy.go +++ b/go/vt/vtgateproxy/vtgateproxy.go @@ -81,7 +81,8 @@ func (proxy *VTGateProxy) getConnection(ctx context.Context, target string) (*vt return existingConn, nil } - // Otherwise create a new connection. + // Otherwise create a new connection. TODO: confirm this doesn't actually make a TCP connection, and returns quickly, + // otherwise we're going to have to do this while not holding the lock. conn, err := vtgateconn.DialProtocol(ctx, "grpc", target) if err != nil { return nil, err