bugfixes from run #213
bugfixes from run #213
Conversation
|
@dylanmkennedy can you verify the correct shape for rmat validation? |
| results = { | ||
| "emittance": emittance, | ||
| "BMAG": bmag, | ||
| results = results | { |
There was a problem hiding this comment.
My $.02.
results.update() would be more efficient than |. Perhaps |= would be just as efficient.
Another consideration, the | operator only works with Python 3.9+. This would be an unnecessary breaking change. 3.8 is just at end of life. Yes, people should update, but environments are not always up to date, e.g. (I believe) RHEL7 is still used actively at SLAC.
In general, I find overloaded operators harder to read. I had to double-take this line in a cursory glance. Named functions are easy for humans to read, especially humans unfamiliar with the latest features, which busy physicists usually are. Also, using the "latest and greatest" (unless it is necessary) does not improve readability.
| @@ -73,7 +73,7 @@ def image(self) -> np.ndarray: | |||
| the camera associated with this screen | |||
| """ | |||
| return self.controls_information.PVs.image.get(as_numpy=True).reshape( | |||
| self.n_rows, self.n_columns | |||
| self.n_columns, self.n_rows | |||
There was a problem hiding this comment.
How did this mistake get caught? I think I'm remembering this might not be the case for all cameras. Will approve for now and check with Courtney.
* bugfixes from run * change dict update statement * Update emittance_measurement.py
Fixes the following bugs: