Magnet length branch #216
Magnet length branch #216
Conversation
…erate.py and metadata.py
… field corresponding to magnetic length : l_eff
…ded to 3 decimals
…as a l_eff in GUNB YAML
| ) | ||
| return {} | ||
| if magnet_names and method: | ||
| # Add any additional metadata fields here |
There was a problem hiding this comment.
Method is the method you want to pass for parsing the lcls_elements.csv file.
Since generate.py had already parsed the csv file for other elements I figured we didn't need to duplicate the code here. Idk what your thoughts on this are.
| # self.magnet.l_eff = "a" | ||
| # some trouble with this.... need to change config later. its not forcing | ||
| # revalidation after reassignment since type is optional I believe. | ||
| self.magnet.l_eff = 1.0 |
There was a problem hiding this comment.
This doesn't have to prevent merging, but I think some of these tests can be restructured. We shouldn't assign then check the value? Maybe we can compare object value vs. what's in the csv table instead.
There was a problem hiding this comment.
Can you write this up in an issue? @phys-cgarnier
| ) | ||
| else: | ||
| elements = self._filter_elements_by_fields( | ||
| required_fields=self._required_fields |
There was a problem hiding this comment.
Sorry, I'm not following the logic here? Maybe a Friday thing. So there is no case where something in self._required_fields would be in required_fields?
Updated magnet length branch.