Adding refresh rate pvs and property to screens. #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermind which camera pv to use
…he .refresh_rate property logic is performed to determine what refresh_rate to use
|
can you add a set of tests to the device testing file that validates the property values |
|
closed because the PR comes from a fork and breaks github install actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this pull request is to add refresh rate PVs and a getter method to the screens device class.
Some info that needs to be known beforehand is that many cameras have two refresh rate PVs, but only one is used. In order to determine what PV to use you need to know whether the IOC the camera runs on is a VME or LinuxRT. So I added the PV that tells you that information as well.