Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken docks on master #28

Open
Eiyeron opened this issue Jul 29, 2018 · 5 comments
Open

Broken docks on master #28

Eiyeron opened this issue Jul 29, 2018 · 5 comments

Comments

@Eiyeron
Copy link
Contributor

Eiyeron commented Jul 29, 2018

Hello, I wanted to make a prototype on Love 11.1 and it seems that docks are broken on the master branch. When using docks, nothing in them are visible. No text, button, image... I tested it both on windows and linux versions and nothing changed. One can see barely some garbage one frame or two after clicking on a dock's tab to bring focus on it, but nothing more.

The example code looks like this (don't take account of the deprecation warnings, they're caused by an old loverocks install)
image

@taylorh140
Copy link

taylorh140 commented Nov 11, 2018

It looks like the BeginDock function isn't properly returning a boolean. when I use a local

        for i = 1, 10 do
		local a = imgui.BeginDock("dock_"..i);
            if a then
                imgui.Text("Hello, dock "..i.."!");
				imgui.Text("Hello, dock "..a.."!");
            end
			print("Hello: "..a);
            imgui.EndDock()
        end

I get the error that i cannot concatenate a nil value 'a' which shouldn't happen given that the function should return a bool.

@ericoporto
Copy link

ericoporto commented Jan 19, 2019

I have the same problem, was going crazy here. Couldn't figure out why the error happens.

@flamendless
Copy link

Same here. BeginDock doesnt return anything. Have anyone fixed this?

@flamendless
Copy link

flamendless commented Jul 24, 2019

Hi, ive fixed this dock issue in my fork

@flamendless
Copy link

Now the only issues are:

  • multiple dockspace is broken.
  • SetNextDock - Left, Right, Bottom, Top - not working properly as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants