Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button for adding a party manually #170

Open
Areat352 opened this issue Jul 6, 2024 · 1 comment · May be fixed by #178
Open

Button for adding a party manually #170

Areat352 opened this issue Jul 6, 2024 · 1 comment · May be fixed by #178

Comments

@Areat352
Copy link

Areat352 commented Jul 6, 2024

Hello,

Before, when adding a party manually, it opened the fill-in boxes but the "add a party manually" button stayed in the same place. So you could add a large number by quickly clicking it several time, and start filling the info from top to bottom.
Now, the button come down below the fill-in boxes, so you can't do that.
Is it possible to reverse the change? It's a minor problem, I know, but it's not very ergonomic.

Cordially

@Areat352 Areat352 changed the title Adding a party manually Button for adding a party manually Jul 6, 2024
@Gouvernathor
Copy link
Collaborator

Gouvernathor commented Jul 10, 2024

That will not be part of the "cardify" update, but I'll probably do it eventually.
The rationale for putting it at the bottom is that it added a party at the bottom of the list and not the top. But now that parties are reorderable, it doesn't make much of a difference if the user mistakenly thinks it would end up at the top.

@jjjclarke jjjclarke linked a pull request Jul 30, 2024 that will close this issue
@Gouvernathor Gouvernathor linked a pull request Aug 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants