Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a major update with nested-values and dynamic-keys in core instead of features #236

Open
MOZGIII opened this issue Oct 11, 2019 · 1 comment

Comments

@MOZGIII
Copy link
Contributor

MOZGIII commented Oct 11, 2019

I figured having those hidden behind feature flags does more bad than good: the features are poorly supported and cause runtime panics from the surrounding infrastructure.
This fractures the ecosystem in a way that when one can attempts using a package it can compile and have all interfaces check out, but panic at runtime with something that should've definitely been a compile error not only in rust, but in any modern type-safe language.

@Techcable
Copy link
Member

Enabling nested-values and serde support by default was part of the hypothetical changes mentioned for slog v3

I would consider these feature flags experimental features for now. I agree these should eventually be the defaults, but for now we're not really in a hurry to upgrade to v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants