Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework achievement and quest data processing #296

Open
builder-247 opened this issue Jan 13, 2020 · 0 comments
Open

Rework achievement and quest data processing #296

builder-247 opened this issue Jan 13, 2020 · 0 comments
Labels
help wanted Extra attention is needed refactor Code that should be improved

Comments

@builder-247
Copy link
Member

Currently quest and achievement data is handled inefficiently, causing extra delay to requests and stress on the internal network.

Scope of the refactor:

  1. Move quests and achievements to their own MongoDB collections

    • Make a script migrating the DB(?)

  2. The /players/:id endpoint no longer needs to wait for promise from parseAchievements since total achievement points are now included in the Hypixel API

Some relevant parts of code:

https://github.com/slothpixel/core/blob/master/routes/spec.js#L256-L266

https://github.com/slothpixel/core/blob/master/processors/processPlayerData.js#L131-L136
@builder-247 builder-247 added help wanted Extra attention is needed refactor Code that should be improved labels Jan 13, 2020
This was referenced Jun 13, 2020
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed refactor Code that should be improved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@builder-247