Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regex to verify releaser identity #9

Open
laurentsimon opened this issue Jan 3, 2024 · 2 comments
Open

Support regex to verify releaser identity #9

laurentsimon opened this issue Jan 3, 2024 · 2 comments

Comments

@laurentsimon
Copy link
Collaborator

laurentsimon commented Jan 3, 2024

I've currently hardcoded this for the releaser verification to @refs/heads/main for full ID matching. For versioned releaser, we need more flexibility. I don't think this needs to be in the policy itself. Instead, it can be in the verifier's code, and will be an input to the CLI / GHA as "--releaser-ref-regex" in addition to --release-ref.

The limitation is that if an org starts with head and want to migrate to version, it will be hard. Having it in the policy itself could be more flexible: the org can define multiple roots for each.

@laurentsimon
Copy link
Collaborator Author

I think it's better to have the regex-id in the policy itself. It simplifies verification and makes it more transparent to review / audit/

@laurentsimon laurentsimon changed the title Provide CLI option to use regex to verify identity Support regex to verify releaser identity Jan 25, 2024
@laurentsimon
Copy link
Collaborator Author

This line will also need to be updated https://github.com/laurentsimon/slsa-policy/blob/main/cmd/evaluator/internal/utils/crypto/crypto.go#L255. We need to extract the identity from the cert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant