Fix connection leak when write failed but dial success.

close the connection before return.
smallnest · Jan 25, 2022 · d91707b · d91707b
1 parent 5ea9529
commit d91707b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/client/connection.go b/client/connection.go
@@ -139,6 +139,10 @@ func newDirectHTTPConn(c *Client, network, address string) (net.Conn, error) {
 
 	_, err = io.WriteString(conn, "CONNECT "+path+" HTTP/1.0\n\n")
 	if err != nil {
+		// Dial() success but Write() failed here, close the successfully
+		// created conn before return.
+		conn.Close()
+
 		log.Errorf("failed to make CONNECT: %v", err)
 		return nil, err
 	}