Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission and Tweet relationship #22

Open
srobbin opened this issue Apr 10, 2013 · 5 comments
Open

Submission and Tweet relationship #22

srobbin opened this issue Apr 10, 2013 · 5 comments

Comments

@srobbin
Copy link
Member

srobbin commented Apr 10, 2013

Comment on Rails code:

Right now, the Submission model refers to a tweet_id, but does not have a true ActiveRecord relationship. At some point, we'll want to reconcile that.

@danxoneil
Copy link
Collaborator

On the display side, that means that each record here: http://foodborne.smartchicagoapps.org/admin/submissions will have the originating tweet associated with it, ya?

@srobbin
Copy link
Member Author

srobbin commented Apr 12, 2013

Currently, that page should already show tweet information, if we have it. It just so happens that none of those tweets have the info.

This ticket is about making that relationship more efficient.

@danxoneil
Copy link
Collaborator

UnderstoodSir. Re-classifying as enhancement.

@RaedMan
Copy link
Member

RaedMan commented Apr 26, 2013

Under "View" for the page for individual submission details, "TWITTER HANDLE" row states "EMPTY" for those submissions that replied through Twitter. It should be populating that row with the known Twitter Handle noted from the "In Reply To" Column listed in the previous page or is this entry supposed to be filled out by the resident?

@srobbin
Copy link
Member Author

srobbin commented May 3, 2013

I think, in the original app, the user would fill in that field. However, once we started recording referring tweet, we stopped displaying that as a form option. So, now it just sits there, blank and lonely.

Would it be helpful to have that filled out in addition to the "Reply To" column, or should I just delete it to avoid any confusion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants