From a77e51e08067cd2f3a5046c4160e8210c7f76a97 Mon Sep 17 00:00:00 2001 From: Silas Lenihan <32529249+silaslenihan@users.noreply.github.com> Date: Tue, 31 Dec 2024 13:25:36 -0500 Subject: [PATCH] fix: golangci loopref linter --- .golangci.yml | 2 +- pkg/solana/config_tracker.go | 1 - pkg/solana/report_test.go | 1 - pkg/solana/txm/pendingtx_test.go | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index d0542f400..6744196f9 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -3,7 +3,7 @@ run: linters: enable: - exhaustive - - exportloopref + - copyloopvar - revive - goimports - gosec diff --git a/pkg/solana/config_tracker.go b/pkg/solana/config_tracker.go index 3ddff2715..425e62d46 100644 --- a/pkg/solana/config_tracker.go +++ b/pkg/solana/config_tracker.go @@ -31,7 +31,6 @@ func ConfigFromState(ctx context.Context, state State) (types.ContractConfig, er return types.ContractConfig{}, err } for _, o := range oracles { - o := o // https://github.com/golang/go/wiki/CommonMistakes#using-reference-to-loop-iterator-variable pubKeys = append(pubKeys, o.Signer.Key[:]) accounts = append(accounts, types.Account(o.Transmitter.String())) } diff --git a/pkg/solana/report_test.go b/pkg/solana/report_test.go index 84452dada..eab16e26b 100644 --- a/pkg/solana/report_test.go +++ b/pkg/solana/report_test.go @@ -143,7 +143,6 @@ func TestMedianFromReport(t *testing.T) { } for _, tc := range tt { - tc := tc t.Run(tc.name, func(t *testing.T) { ctx := tests.Context(t) var pos []median.ParsedAttributedObservation diff --git a/pkg/solana/txm/pendingtx_test.go b/pkg/solana/txm/pendingtx_test.go index a79f9f7aa..f2393d106 100644 --- a/pkg/solana/txm/pendingtx_test.go +++ b/pkg/solana/txm/pendingtx_test.go @@ -1304,7 +1304,6 @@ func TestPendingTxContext_ListAllExpiredBroadcastedTxs(t *testing.T) { } for _, tt := range tests { - tt := tt // capture range variable t.Run(tt.name, func(t *testing.T) { // Initialize a new PendingTxContext ctx := newPendingTxContext()