From 5f1c96ac379a8ed3417d40ce1643cfdce954da1b Mon Sep 17 00:00:00 2001
From: zhanglei <zhanglei@smartx.com>
Date: Wed, 13 Jul 2022 19:05:33 +0800
Subject: [PATCH] test: Fix VM controller tests pod GC error

---
 pkg/controller/vm_controller_test.go | 31 +++++++++++++---------------
 1 file changed, 14 insertions(+), 17 deletions(-)

diff --git a/pkg/controller/vm_controller_test.go b/pkg/controller/vm_controller_test.go
index 4fc648b..8955755 100644
--- a/pkg/controller/vm_controller_test.go
+++ b/pkg/controller/vm_controller_test.go
@@ -10,8 +10,6 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/kubernetes"
-	"k8s.io/client-go/kubernetes/scheme"
-	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
 
 	virtv1alpha1 "github.com/smartxworks/virtink/pkg/apis/virt/v1alpha1"
 )
@@ -213,25 +211,24 @@ var _ = Describe("VM controller", func() {
 			}
 			Expect(k8sClient.Create(ctx, &vm)).To(Succeed())
 
-			By("creating the VM pod")
+			By("updating VM phase to Scheduling")
 			vmPodKey = types.NamespacedName{
 				Name:      uuid.New().String(),
 				Namespace: vmKey.Namespace,
 			}
-			vmPod := corev1.Pod{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      vmPodKey.Name,
-					Namespace: vmPodKey.Namespace,
-				},
-				Spec: corev1.PodSpec{
-					Containers: []corev1.Container{{
-						Name:  "container",
-						Image: "image",
-					}},
-				},
-			}
-			Expect(controllerutil.SetControllerReference(&vm, &vmPod, scheme.Scheme)).To(Succeed())
-			Expect(k8sClient.Create(ctx, &vmPod)).To(Succeed())
+			Eventually(func() bool {
+				var vm virtv1alpha1.VirtualMachine
+				Expect(k8sClient.Get(ctx, vmKey, &vm)).To(Succeed())
+				vm.Status.Phase = virtv1alpha1.VirtualMachineScheduling
+				vm.Status.VMPodName = vmPodKey.Name
+				return k8sClient.Status().Update(ctx, &vm) == nil
+			}).Should(BeTrue())
+
+			By("checking the VM pod has been created")
+			Eventually(func() bool {
+				var vmPod corev1.Pod
+				return k8sClient.Get(ctx, vmPodKey, &vmPod) == nil
+			}).Should(BeTrue())
 
 			By("binding the VM pod")
 			nodeName := uuid.New().String()