Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change infill to detect "roofs" and "floors" #785

Closed
frank-vanderhulst opened this issue Nov 5, 2023 · 2 comments
Closed

Change infill to detect "roofs" and "floors" #785

frank-vanderhulst opened this issue Nov 5, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@frank-vanderhulst
Copy link

Is your feature request related to a problem?

Infill does not detect intermediate horizontal "roofs" or "floors" in the model.

It leaves a solid "floor" from 0 to the specified "from" layer, and a solid "roof" from the specified "to" layer to the top of the model, and it generates solid walls of the requested thickness. However, if there is a horizontal surface larger than (wall thickness * 2) below the top layers it does not leave it as a solid layer, so that the infill is visible. In the example files, see layer 826 and 1156.

This only applies to horizontal (or nearly horizontal) layers. Sloping layers are visually OK so long as the wall of one layer overlaps the wall of the next. However, their walls may be quite thin. e.g. in the extreme case where the slope of a wall is 1 in "wall thickness", the thickness of the wall, orthogonal to the slope, will be only 1 pixel.

Describe the solution you'd like

Quick solution:
Detect horizontal surfaces larger than (2 * wall thickness) in both X & Y dimensions and leave them solid for "wall thickness" layers.

Better solution:
Change the calculation of wall thickness to a 3D model, so that walls are the same thickness, no matter what slope they're at.

Files

E.zip
20231106_085604

@frank-vanderhulst frank-vanderhulst added the enhancement New feature or request label Nov 5, 2023
Copy link

github-actions bot commented Nov 5, 2023

This is your first time submitting an issue with UVtools 🥳Please review your issue and ensure that the submit template was followed, the information is complete, and not related to any other open issue. It will be reviewed shortly. Debugging is very important and make the program better. Thanks for contributing and making the software better! 🙌

sn4k3 added a commit that referenced this issue Nov 9, 2023
- **FileFormat Anycubic:**
  - (Fix) Preview marker size and `PropertyFields` for given file version
  - (Fix) Do not cache and reuse layer images if equal on file write, as that is causing "file damage" message (#782, #787)
- **Tools:**
  - **Mask:**
    - (Improvement) Apply the mask with Multiply instead of BitwiseAnd (#747)
  - **Layer and pixel arithmetic**:
    - (Improvement) Use the byte scale value (1/255) for multiply operations
  - **Infill:**
    - (Add) Floor/Ceil thickness (#785)
    - (Fix) Remove the debug blocking window when selecting the honeycomb pattern
- (Upgrade) .NET from 6.0.23 to 6.0.24
@sn4k3
Copy link
Owner

sn4k3 commented Nov 9, 2023

Implemented

@sn4k3 sn4k3 closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants