Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition: replies get dropped if their in-reply-to post is still processing #1361

Open
qazmlp opened this issue Oct 5, 2024 · 3 comments

Comments

@qazmlp
Copy link

qazmlp commented Oct 5, 2024

A reply just (sporadically?) didn't make it to Bluesky. The log at https://fed.brid.gy/log?path=%2Fqueue%2Fwebmention%2C%2Finbox&start_time=1728105708&key=https%3A%2F%2Fwolfdo.gg%2Fnotes%2F9yz9tw8dfgws6ex9%2Factivity shows the following

I 2024-10-05 05:21:46.205812+00:00 Already seen this activity https://wolfdo.gg/notes/9yz9tw8dfgws6ex9/activity

Relevant thread on Bluesky: https://bsky.app/profile/qazm.bsky.social/post/3l5qmbrxis223

That looks like a race condition somewhere in the ActivityPub inbox to me.
(This activity doesn't have the green checkmark for delivering it to Bluesky.)

@snarfed
Copy link
Owner

snarfed commented Oct 5, 2024

Hah, race condition indeed. That reply (call it B) was to another reply (A) by the same author that was still processing when B came in. BF saw that A wasn't bridged, so it didn't bridge B either, due to the logic that replies to non-bridged post aren't bridged.

Ugh. I can think of ways to solve this, but they're all complicated. I don't see an easy fix yet.

(The log message was unrelated, we got two inbox deliveries of this reply and that log message was for the second one. Our logic for finding log messages is not the best 🤷)

@snarfed snarfed changed the title AP => AT reply dropped erroneously Race condition: replies get dropped if their in-reply-to post is still processing Oct 5, 2024
@TomCasavant
Copy link

Let me know if you want me to file a different issue for this, but I'm pretty sure this is related to this issue

https://fed.brid.gy/ap/@[email protected] <- this bot auto reposts any post from https://fed.brid.gy/ap/@[email protected] if certain conditions are met and it boosts them basically immediately after the post is created. It looks like Bridgy is seeing the boost but doesn't do anything about it (I'm guessing because Bridgy hasn't processed the original post yet)

@snarfed
Copy link
Owner

snarfed commented Oct 14, 2024

Ah, interesting, true! That does sound likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants