Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup ginkgo linter #8

Closed
plastikfan opened this issue Aug 11, 2023 · 2 comments · Fixed by #14
Closed

setup ginkgo linter #8

plastikfan opened this issue Aug 11, 2023 · 2 comments · Fixed by #14
Assignees
@plastikfan
Labels
chore Non source related, infrasture change

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Aug 11, 2023 •
edited
Loading

See: ginkgolinter
@plastikfan plastikfan added the chore Non source related, infrasture change label Aug 11, 2023
@plastikfan plastikfan self-assigned this Aug 11, 2023
@plastikfan plastikfan changed the title add ginkgo linter setup ginkgo linter Aug 11, 2023
@plastikfan
Copy link
Contributor Author

plastikfan commented Aug 11, 2023 •
edited
Loading

Very easy to do, just do the following

  • install the cli:
go install github.com/nunnatsa/ginkgolinter/cmd/ginkgolinter@latest

  • add "- ginkgolinter" to golangci.yml

  • To apply fix just run:

ginkgolinter -fix ./...

plastikfan added a commit that referenced this issue Aug 11, 2023
@plastikfan
chore: setup ginkgo linter (#8)
1c76e2f
plastikfan added a commit that referenced this issue Aug 11, 2023
@plastikfan
chore: setup ginkgo linter (#8)
aacc8ca
@plastikfan plastikfan linked a pull request Aug 11, 2023 that will close this issue
chore: setup ginkgo linter (#8) #14
Merged
@plastikfan plastikfan pinned this issue Aug 11, 2023
plastikfan added a commit that referenced this issue Aug 14, 2023
@plastikfan
chore: setup ginkgo linter (#8)
5e243be
@plastikfan plastikfan mentioned this issue Aug 25, 2023
Closed
@plastikfan
Copy link
Contributor Author

If you ever see linter failures in CI that don't occur locally, then this is because there is a difference of the version of golang-cilint that is being run. Always make sure that they are the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plastikfan plastikfan

Labels
chore Non source related, infrasture change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: setup ginkgo linter (#8) snivilised/lorax
1 participant
@plastikfan