Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send event to Sentry when event can't be inserted to ES good index #167

Open
benjben opened this issue Jul 3, 2020 · 6 comments
Open

Send event to Sentry when event can't be inserted to ES good index #167

benjben opened this issue Jul 3, 2020 · 6 comments
Assignees
Milestone

Comments

@benjben
Copy link
Contributor

benjben commented Jul 3, 2020

On top of a bad row being emitted, we want to be notified when this happens to detect ASAP ES mapping failures with union types.

@benjben benjben self-assigned this Jul 3, 2020
@benjben benjben added this to the 0.12.2 milestone Jul 3, 2020
@jbeemster
Copy link
Member

Worth windowing this a bit - on a large pipeline this could be thousands of events failing! You might need some form of internal counter which flushes to Sentry every N minutes to protect the Sentry server from accidental DDoS.

@benjben
Copy link
Contributor Author

benjben commented Jul 3, 2020

You're right. We're sending events to ES per batch, so we can send only one notification to Sentry per batch.

@jbeemster
Copy link
Member

Even per batch it could be a lot - the batch is determined by the sink parameters (time, bytes, record count) if I understand correctly. If your time-limit is say 100ms then you could get 10 failures per second coming to Sentry (extrapolating out to 864,000 per day at that rate if consistent). This is obviously a very pessimistic view but could eventuate...

@benjben
Copy link
Contributor Author

benjben commented Jul 3, 2020

Do we pay for a maximum number of events sent to Sentry ?

@jbeemster
Copy link
Member

No - but we will need to scale up Sentry enormously if we send huge volume to it :)

@benjben
Copy link
Contributor Author

benjben commented Jul 3, 2020

Oh we are self hosting it ! I had missed this bit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants