Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification regarding sinkFile and sinkFileBS #483

Open
bitc opened this issue Mar 8, 2022 · 1 comment
Open

Clarification regarding sinkFile and sinkFileBS #483

bitc opened this issue Mar 8, 2022 · 1 comment

Comments

@bitc
Copy link

bitc commented Mar 8, 2022

Hello,

The function sinkFileBS says that it is:

sinkFile specialized to ByteString to help with type inference.

But it has the exact same type signature and implementation as sinkFile. I am guessing that at one point in history there was a difference.

But it looks like now they are the same, so can one of these functions be deprecated, or the documentation clarified?

Thank you

@snoyberg
Copy link
Owner

snoyberg commented Mar 8, 2022

Good catch. I think updating the docs to say that sinkFileBS is now redundant with sinkFile would be a good change. PR would be welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants