Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bug - Segmentation fault on layer push_back on VGG16 #34

Open
HuangPZ opened this issue Mar 17, 2022 · 5 comments
Open

New bug - Segmentation fault on layer push_back on VGG16 #34

HuangPZ opened this issue Mar 17, 2022 · 5 comments

Comments

@HuangPZ
Copy link

HuangPZ commented Mar 17, 2022

network = "VGG16";
dataset = "CIFAR10"; // or ImageNet

Segmentation fault is detected when pushing back the 31st layer (an FC layer) to layers. This occurred on my two machines so I think it's a machine issue. Tried to fix it myself but didn't quite get the reason for the issue. I see the repo is updated a lot since I first checked, please do investigate this issue to see if the bug can be reproduced.

@snwagh
Copy link
Owner

snwagh commented Mar 18, 2022

There haven't been any major changes to that part of the code. Can you please paste the changes you've made and the machine config you're running it on? It is nearly impossible to debug without a concrete bug. An issue occurring on two out of three machines would indicate that it might not be an issue with the repo.

@HuangPZ
Copy link
Author

HuangPZ commented Mar 18, 2022

Hi! I meant running
make terminal
using localhost setting on a single machine, and I encountered the error. I tried on two different machines and got the same error. I've updated to the newest version of the code when commenting.

@snwagh
Copy link
Owner

snwagh commented Mar 19, 2022

Thanks for spotting the bug, I was able to reproduce it on some machine.

The issue is arising from the constructor of the FC Layer class and more specifically from the initialization (these few lines of code). I still do not know what the cause of the seg fault is but maybe you can take a stab at debugging it from here?

@AndesPooh258 Since you worked on this commit (3d3e8f2), can you please help @HuangPZ with this bug?

@andeskyl
Copy link
Contributor

As I am dealing with mutliple project deadlines, I am sorry that I may not have time to help at this moment. But the high level idea of this modified part of code is to initialize non-zero weights for the FC layer. That said, if you don't mind to initialize the weight of FC layer as 0, you may feel free to comment these part of code and see if this error occurs.

@HuangPZ
Copy link
Author

HuangPZ commented Apr 7, 2022

As I am dealing with mutliple project deadlines, I am sorry that I may not have time to help at this moment. But the high level idea of this modified part of code is to initialize non-zero weights for the FC layer. That said, if you don't mind to initialize the weight of FC layer as 0, you may feel free to comment these part of code and see if this error occurs.

This indeed worked. Maybe we want to figure out what's happening later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants