Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compound document rule does not detect includes #353

Open
cmars opened this issue Sep 7, 2022 · 1 comment
Open

Compound document rule does not detect includes #353

cmars opened this issue Sep 7, 2022 · 1 comment

Comments

@cmars
Copy link
Contributor

cmars commented Sep 7, 2022

Typo in

sweater-comb/src/rulesets/rest/2022-05-25/json-api-rules/compound-document-rules.ts

Line 14 in a641c5a

included: {},
, we should be catching includes rather than included.

This'll be much easier to unit test with the new DSL...
@cmars
Copy link
Contributor Author

cmars commented Sep 7, 2022

Should expand on this to restrict what keys are allowed in the top-level document. Only jsonapi, data, meta and links should really be allowed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmars