Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tests for flow types #21

Open
sobolevn opened this issue Jun 11, 2018 · 0 comments
Open

Support tests for flow types #21

sobolevn opened this issue Jun 11, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sobolevn
Copy link
Owner

We need to tests that types are working. For this specific case there's such a thing as flow type-testing: https://github.com/flowtype/flow-typed/blob/master/definitions/npm/axios_v0.18.x/test_axios_v0.18.x.js

We need to cover existing libs with tests. That's how I see it:
0. We implement a required .flowconfig file with the correct settings (it can be copied from flow-typed

  1. The source packages we write tests for are added as a dev-dependencies into the each package that uses this library
  2. Then we write flow tests
@sobolevn sobolevn added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant