Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement prefork which invokes bundler. #3

Closed
ioquatix opened this issue Feb 16, 2019 · 4 comments
Closed

Implement prefork which invokes bundler. #3

ioquatix opened this issue Feb 16, 2019 · 4 comments

Comments

@ioquatix
Copy link
Member

socketry/falcon#53

  • Implement Async::Container::Preforked which supports a similar interface to Async::Container::Forked (maybe extract common functionality).
  • Pre-fork should fork once, then invoke Bundler.require with an appropriate bundler group (open to ideas, could be hard coded to:preforked or perhaps something more generic). The pre-fork process should spawn children processes, maybe by invoking Async::Container::Forked.
  • Relevant specs.
@ioquatix
Copy link
Member Author

Also, I'm fine with the prefork process using exec to replace itself. I'm not sure how well it can work w.r.t passing sockets and other things to child process, but lets try it?

@ioquatix
Copy link
Member Author

@bryanp feel free to join https://gitter.im/socketry/async to discuss any related issues

@ioquatix
Copy link
Member Author

On the following point:

  • Pre-fork should fork once, then invoke Bundler.require with an appropriate bundler group (open to ideas, could be hard coded to:preforked or perhaps something more generic). The pre-fork process should spawn children processes, maybe by invoking Async::Container::Forked.

I wonder if it's better to take a block/proc/callback or just invoke a method on the class, so it can be changed by subclass/injection/proc.

@ioquatix
Copy link
Member Author

Okay, this was implemented and is essentially done by using Instance#exec("bundler", "exec", ...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant