Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Prepare cheat code in rust and update Deploy logic #1991

Open
karol-bisztyga opened this issue May 26, 2023 · 3 comments
Open

Investigate Prepare cheat code in rust and update Deploy logic #1991

karol-bisztyga opened this issue May 26, 2023 · 3 comments
Labels
blocked
Milestone
Rust test runner

Comments

@karol-bisztyga
Copy link
Contributor

karol-bisztyga commented May 26, 2023 •
edited by cptartur
Loading

We should add the code for the Prepare cheat code.
The implementation should be put here.

We were considering using starknet_in_rust and blockifier, and we decided to go with the latter.

Deploy cheatcode logic should be updated, so it only accepts PreparedContract with correctly computed contract_address. In case of trying to use deploy with incorrect contract_address, it should fail.
@karol-bisztyga karol-bisztyga added this to the Rust test runner milestone May 26, 2023
@karol-bisztyga karol-bisztyga added the asap This task blocks/conflicts with another tasks or is very important label May 26, 2023
@karol-bisztyga karol-bisztyga self-assigned this May 29, 2023
@MaksymilianDemitraszek MaksymilianDemitraszek removed the asap This task blocks/conflicts with another tasks or is very important label Jun 13, 2023
@cptartur cptartur mentioned this issue Jun 28, 2023
Closed
3 tasks
@Arcticae
Copy link
Member

Blocked by #2072

@cptartur cptartur changed the title Implement Prepare cheat code in rust Implement Prepare cheat code in rust and update Deploy logic Jun 29, 2023
@cptartur cptartur mentioned this issue Jun 29, 2023
Merged
3 tasks
@piotmag769
Copy link
Contributor

We should update tests for deploy as well #2132 (comment)

@cptartur cptartur changed the title Implement Prepare cheat code in rust and update Deploy logic Investigate Prepare cheat code in rust and update Deploy logic Jul 4, 2023
@cptartur
Copy link
Member

cptartur commented Jul 4, 2023

We should discuss what is the correct approach for precalculating contract addresses.

We should address the fact that PreparedContract.contract_address is completely ignored in deploy cheat.

cc @MaksymilianDemitraszek @Arcticae

@cptartur cptartur mentioned this issue Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
Rust test runner
Development

No branches or pull requests
5 participants
@MaksymilianDemitraszek @Arcticae @cptartur @piotmag769 @karol-bisztyga