From 8648886cb170c8d4c96393edc39f29ce22905796 Mon Sep 17 00:00:00 2001 From: soheil khaledabadi Date: Fri, 5 Apr 2024 00:44:05 +0330 Subject: [PATCH] Clean code -> run laravel pint --- app/Constants/OrderConstants.php | 3 --- .../api/{ => v1}/AuthController.php | 3 ++- .../api/{ => v1}/BasketController.php | 15 +++++++------- .../api/{ => v1}/CommentController.php | 2 +- .../api/{ => v1}/HomeController.php | 3 ++- .../api/{ => v1}/LikeController.php | 2 +- .../Controllers/api/v1/OrderController.php | 15 +++++++------- .../api/{ => v1}/ProductController.php | 2 +- .../api/{ => v1}/ProfileController.php | 2 +- app/Http/Requests/Basket/BasketBuyRequest.php | 1 + .../Requests/Basket/BasketDeleteRequest.php | 1 - app/Models/Address.php | 2 +- app/Models/Order.php | 6 +++--- app/Models/OrderProduct.php | 2 +- .../2024_02_04_142723_create_orders_table.php | 2 +- ...4_02_23_111738_add_code_to_order_table.php | 2 +- routes/api.php | 20 +++++++++---------- 17 files changed, 41 insertions(+), 42 deletions(-) rename app/Http/Controllers/api/{ => v1}/AuthController.php (95%) rename app/Http/Controllers/api/{ => v1}/BasketController.php (92%) rename app/Http/Controllers/api/{ => v1}/CommentController.php (96%) rename app/Http/Controllers/api/{ => v1}/HomeController.php (99%) rename app/Http/Controllers/api/{ => v1}/LikeController.php (95%) rename app/Http/Controllers/api/{ => v1}/ProductController.php (98%) rename app/Http/Controllers/api/{ => v1}/ProfileController.php (97%) diff --git a/app/Constants/OrderConstants.php b/app/Constants/OrderConstants.php index 62e75d8..3ca8604 100644 --- a/app/Constants/OrderConstants.php +++ b/app/Constants/OrderConstants.php @@ -14,9 +14,6 @@ class OrderConstants public const CANCELLED = 'cancelled'; - - - public static function getStatusFromId($id) { switch ($id) { diff --git a/app/Http/Controllers/api/AuthController.php b/app/Http/Controllers/api/v1/AuthController.php similarity index 95% rename from app/Http/Controllers/api/AuthController.php rename to app/Http/Controllers/api/v1/AuthController.php index 2b6d918..9e774b1 100644 --- a/app/Http/Controllers/api/AuthController.php +++ b/app/Http/Controllers/api/v1/AuthController.php @@ -1,7 +1,8 @@ success(BasketResource::collection($baskets), 'success', 'Product successfully.'); } - public function add(BasketRequest $request): JsonResponse { $userId = auth()->user()->id; @@ -66,7 +65,7 @@ public function delete(BasketDeleteRequest $request): JsonResponse return $this->success(null, 'success', 'Basket item not found or you do not have permission to delete it.'); } - public function buy(BasketBuyRequest $request) + public function buy(BasketBuyRequest $request): JsonResponse { $validated = $request->validated(); if (auth()->user()->baskets()->where('status', 'created')->count() == 0) { @@ -75,7 +74,7 @@ public function buy(BasketBuyRequest $request) $products = auth()->user()->baskets()->where('status', 'created')->get(); auth()->user()->baskets()->where('status', 'created')->update([ - 'status' => 'paid' + 'status' => 'paid', ]); $method = ''; @@ -94,17 +93,17 @@ public function buy(BasketBuyRequest $request) 'code' => rand(), 'user_id' => auth()->user()->id, 'address_id' => $validated['address_id'], - 'method' => $method + 'method' => $method, ]); - foreach($products as $product){ + foreach ($products as $product) { OrderProduct::query()->create([ 'order_id' => $order->id, 'product_id' => $product->id, - 'count' => $product->count + 'count' => $product->count, ]); } - + return $this->success(null, 'Success', 'Your purchase was successful'); } } diff --git a/app/Http/Controllers/api/CommentController.php b/app/Http/Controllers/api/v1/CommentController.php similarity index 96% rename from app/Http/Controllers/api/CommentController.php rename to app/Http/Controllers/api/v1/CommentController.php index ab4d281..d277a74 100644 --- a/app/Http/Controllers/api/CommentController.php +++ b/app/Http/Controllers/api/v1/CommentController.php @@ -1,6 +1,6 @@ select('id', 'name', 'parent', 'icon')->get(); $address = auth()->user()->address()->first() ? new AddressResource(auth()->user()->address()->first()) : null; + return $this->success([ 'banners' => $banners, 'categories' => $categories, diff --git a/app/Http/Controllers/api/LikeController.php b/app/Http/Controllers/api/v1/LikeController.php similarity index 95% rename from app/Http/Controllers/api/LikeController.php rename to app/Http/Controllers/api/v1/LikeController.php index fa13fe9..a3eb2bc 100644 --- a/app/Http/Controllers/api/LikeController.php +++ b/app/Http/Controllers/api/v1/LikeController.php @@ -1,6 +1,6 @@ getOrdersByStatus(); + return $this->success($orders, 'Order', 'Order list completed'); } catch (\Exception $e) { - Log::error('Error retrieving orders: ' . $e->getMessage()); + Log::error('Error retrieving orders: '.$e->getMessage()); + return $this->failed(null, 'Error', 'An error occurred while fetching orders.'); } } @@ -46,7 +47,7 @@ protected function mapProducts($products) return [ 'title' => $product?->product?->title, 'image' => $product?->product?->image, - 'price' => $product?->product?->price + 'price' => $product?->product?->price, ]; }); } @@ -54,10 +55,10 @@ protected function mapProducts($products) protected function mapAddress($address) { return [ - "address" => $address->address, - "city" => $address->city, - "county" => $address->county, - "state" => $address->state, + 'address' => $address->address, + 'city' => $address->city, + 'county' => $address->county, + 'state' => $address->state, ]; } diff --git a/app/Http/Controllers/api/ProductController.php b/app/Http/Controllers/api/v1/ProductController.php similarity index 98% rename from app/Http/Controllers/api/ProductController.php rename to app/Http/Controllers/api/v1/ProductController.php index 80c96e6..352312f 100644 --- a/app/Http/Controllers/api/ProductController.php +++ b/app/Http/Controllers/api/v1/ProductController.php @@ -1,6 +1,6 @@ hasMany(OrderProduct::class); } diff --git a/app/Models/OrderProduct.php b/app/Models/OrderProduct.php index fc13ffc..fe4489f 100644 --- a/app/Models/OrderProduct.php +++ b/app/Models/OrderProduct.php @@ -12,7 +12,7 @@ class OrderProduct extends Model protected $fillable = [ 'order_id', 'product_id', - 'count' + 'count', ]; public function product() diff --git a/database/migrations/2024_02_04_142723_create_orders_table.php b/database/migrations/2024_02_04_142723_create_orders_table.php index b658295..350a00d 100644 --- a/database/migrations/2024_02_04_142723_create_orders_table.php +++ b/database/migrations/2024_02_04_142723_create_orders_table.php @@ -15,7 +15,7 @@ public function up(): void $table->id(); $table->foreignId('user_id'); $table->foreignId('address_id'); - $table->enum('method',['economy','regular','cargo','express']); + $table->enum('method', ['economy', 'regular', 'cargo', 'express']); $table->timestamps(); }); } diff --git a/database/migrations/2024_02_23_111738_add_code_to_order_table.php b/database/migrations/2024_02_23_111738_add_code_to_order_table.php index 87efea9..0d8e787 100644 --- a/database/migrations/2024_02_23_111738_add_code_to_order_table.php +++ b/database/migrations/2024_02_23_111738_add_code_to_order_table.php @@ -13,7 +13,7 @@ public function up(): void { Schema::table('orders', function (Blueprint $table) { $table->string('code')->after('id')->nullable(); - $table->enum('status',['active','created','success','failed','cancelled'])->after('code')->default('success'); + $table->enum('status', ['active', 'created', 'success', 'failed', 'cancelled'])->after('code')->default('success'); }); } diff --git a/routes/api.php b/routes/api.php index ee9d72f..96544f8 100644 --- a/routes/api.php +++ b/routes/api.php @@ -1,13 +1,13 @@ group(function () { @@ -37,11 +37,11 @@ Route::get('', [BasketController::class, 'index'])->name('api.basket'); Route::post('add', [BasketController::class, 'add'])->name('api.basket.add'); Route::post('delete', [BasketController::class, 'delete'])->name('api.basket.delete'); - Route::post('buy',[BasketController::class, 'buy'])->name('api.basket.buy'); + Route::post('buy', [BasketController::class, 'buy'])->name('api.basket.buy'); }); - Route::prefix('orders')->group(function(){ - Route::get('',[OrderController::class,'index']); + Route::prefix('orders')->group(function () { + Route::get('', [OrderController::class, 'index']); }); Route::get('address', [ProfileController::class, 'address'])->name('api.address');