diff --git a/.circleci/config.yml b/.circleci/config.yml index 1e753503a88..e07188dacd3 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -232,27 +232,6 @@ commands: bundle exec rake -rrails -rspree/testing_support/extension_rake -e'Rake::Task["extension:test_app"].invoke' jobs: - lint_code: - docker: - - image: cimg/ruby:3.2-node - environment: - BUNDLE_ONLY: "lint" - ESLINT_USE_FLAT_CONFIG: false - steps: - - checkout - - run: "bundle install" - - run: - name: Check Ruby - command: "bin/rake lint:rb" - - run: - name: Check ERB - command: "bin/rake lint:erb" - - run: - name: Check JavaScript - command: "bin/rake lint:js" - - store_test_results: - path: test-results - solidus_installer: executor: name: sqlite @@ -362,7 +341,6 @@ jobs: workflows: build: jobs: - - lint_code - solidus_installer - test_solidus_with_coverage # Only test with coverage support with the default versions diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml new file mode 100644 index 00000000000..98d53406039 --- /dev/null +++ b/.github/workflows/lint.yml @@ -0,0 +1,62 @@ +name: Lint + +on: [pull_request] + +concurrency: + group: lint-${{ github.ref_name }} + cancel-in-progress: ${{ github.ref_name != 'main' }} + +permissions: + contents: read + +env: + BUNDLE_ONLY: "lint" + +jobs: + ruby: + name: Check Ruby + runs-on: ubuntu-22.04 + steps: + - name: Checkout code + uses: actions/checkout@v3 + - name: Install Ruby and gems + uses: ruby/setup-ruby@v1 + with: + ruby-version: "3.2" + bundler-cache: true + - name: Lint Ruby files + run: bin/rake lint:rb + - name: Store test results + uses: actions/upload-artifact@v4 + with: + name: rubocop-results + path: test-results + + erb: + name: Check ERB + runs-on: ubuntu-22.04 + steps: + - name: Checkout code + uses: actions/checkout@v3 + - name: Install Ruby and gems + uses: ruby/setup-ruby@v1 + with: + ruby-version: "3.2" + bundler-cache: true + - name: Lint ERB files + run: bin/rake lint:erb + + javascript: + name: Check JavaScript + runs-on: ubuntu-22.04 + env: + ESLINT_USE_FLAT_CONFIG: false + steps: + - uses: actions/checkout@v3 + - name: Install Ruby and gems + uses: ruby/setup-ruby@v1 + with: + ruby-version: "3.2" + bundler-cache: true + - name: Lint JS files + run: bin/rake lint:js