Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEO / Structured Data] Define main taxon for usage in breadcrumbs #6047

Open
fthobe opened this issue Dec 20, 2024 · 7 comments
Open

[SEO / Structured Data] Define main taxon for usage in breadcrumbs #6047

fthobe opened this issue Dec 20, 2024 · 7 comments

Comments

@fthobe
Copy link
Contributor

fthobe commented Dec 20, 2024

@rahulsingh321

Desired Behavior
Considering Starter Frontend Issue #130

Currently breadcrumbs are not necessarily generated correctly as multiple taxons can be picked to load them in the store front.

Quoting @tvdeyen

Every shop I worked with has a different understanding of what the main taxonomy (most of the time referred to as "Category") is. Some refer to as the "Storefront" taxonomy, some call it "Navigation", etc. I can see that there is an urge for at least something that is been used as the main product category.

We could make it configurable and default to a taxonomy with a "Category" name or add a flag to the taxonomies table (ie. main_category).

I am open to suggestions.

If introducing a main_taxon is ok for everybody that's fine for me and we could implement that.

@fthobe fthobe changed the title [SEO / Structured Data] [SEO / Structured Data] Define main taxon for usage in breadcrumbs Dec 20, 2024
@kennyadsl
Copy link
Member

What about a flag on the taxonomy, similar to default_for_breadcrumbs. "Main" doesn't have a good semantic IMHO.

@fthobe
Copy link
Contributor Author

fthobe commented Dec 21, 2024

Hi @kennyadsl do you mean that a taxon is flagged as a primary taxon for all products related? Sorry I am trying to understand your approach better as currently the issue is that there are too many taxons possible taxons to reliably render breadcrumbs and I feel we just shift the problem instead of solving it if we don't create a simple 1 product has many taxons but one primary taxing relation to generate the breadcrumbs instead of creating a scenario where multiple primary taxons can be associated to one taxon. I found what @tvdeyen wrote spot on and felt it was a good comment. Can we settle for that approach?

@fthobe
Copy link
Contributor Author

fthobe commented Jan 30, 2025

@kennyadsl default_for_breadcrumbs is a little long, is breadcrumb_taxon fine?

@kennyadsl
Copy link
Member

kennyadsl commented Jan 30, 2025

use_for_breadcrumbs or breadcrumbs_source?

@fthobe
Copy link
Contributor Author

fthobe commented Jan 30, 2025

Man, whatever makes you happy and creates something that is merged.

Follow the breadcrumbs to reach the PR... 🍞

@rahulsingh321 use breadcrumbs_source
@kennyadsl what label in the admin interface?

@kennyadsl
Copy link
Member

You get this started by complaining for the long column name! 😆
For breadcrumbs_taxon, my point is that you are adding the column to the taxon table, it's useless to repeat that that value refers to a taxon. You'll have taxon.breadcrumb_taxon, which is redundant.

I'm ok with whatever name, just use your common sense.

@fthobe
Copy link
Contributor Author

fthobe commented Jan 31, 2025

You get this started by complaining for the long column name! 😆
For breadcrumbs_taxon, my point is that you are adding the column to the taxon table, it's useless to repeat that that value refers to a taxon. You'll have taxon.breadcrumb_taxon, which is redundant.

I'm ok with whatever name, just use your common sense.

Honestly we went for a selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants