Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Acronym for UI breaks other gems/engines #6075

Open
brandonjyuhas opened this issue Jan 15, 2025 · 0 comments
Open

Custom Acronym for UI breaks other gems/engines #6075

brandonjyuhas opened this issue Jan 15, 2025 · 0 comments

Comments

@brandonjyuhas
Copy link

Solidus has a custom inflection acronym for "Ui" (changing it to "UI"). This is correct in how UI is used. However, this means that other engines which use the default inflection ("Ui") are broken by default.

This means that to use another gem (such as Maglev), you need to monkeypatch their gem to rename the module.

Defining the inflection of a commonly used acronym within in apps codebase seems entirely outside of the scope of what Solidus provides, and I should be able to use Solidus without it changing the names of constants coming from other gems.

Solidus Version:
4.4.0

To Reproduce

Define a module using the default inflection for ui, "Ui". Alternatively, use a gem (such as Maglev). Note that it cannot be included in any class.

Current behavior
Constants including the default inflection for ui cannot be loaded.

Expected behavior
The default inflection for 'ui' is respected.

Screenshots

Image

Desktop (please complete the following information):

  • OS: OSX
  • Browser: Chrome
  • Version 131.0.6778.265 (Official Build) (arm64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant