Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't order history be inside solidus repo? #123

Open
spaghetticode opened this issue Apr 11, 2018 · 2 comments
Open

Shouldn't order history be inside solidus repo? #123

spaghetticode opened this issue Apr 11, 2018 · 2 comments

Comments

@spaghetticode
Copy link
Member

spaghetticode commented Apr 11, 2018

Hello, I am integrating Solidus ecommerce in an existing app, so I need to use the existing User table.
I am not actually using this gem, but I found out that the user orders history (routes, views and so on) are inside this repo.
I am a bit confused about it, because authentication does not really concern orders, IMHO these parts of code may better belong inside solidus codebase. What's your opinion on this matter?

@tvdeyen
Copy link
Member

tvdeyen commented Apr 11, 2018

Yes, I agree. Would you like to propose a PR to core? This would be very much appreciated.

@spaghetticode
Copy link
Member Author

Alright, I'll work on this soon.

I also noticed that the guest_checkout feature is present in solidus codebase with the preference setting allow_guest_checkout, enabled by default, but to me it seems it's never used there. Again, its functionality is placed in the solidus_auth_devise gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants