Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ABI versions instead of commit Sha's for determining versions #201

Closed
Sodman opened this issue Oct 15, 2020 · 1 comment
Closed

Use ABI versions instead of commit Sha's for determining versions #201

Sodman opened this issue Oct 15, 2020 · 1 comment
Assignees
@Sodman
Labels
enhancement New feature or request

Comments

@Sodman
Copy link
Member

Sodman commented Oct 15, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
Update wasme's ABI version handling logic to use ABI versions (0_2_0, 0_2_1, etc) rather than the current commit hashes. As envoy-wasm has been upstreamed into envoy now, we can assume these versions will be more stable going forward.

For now we're keeping the old commit-hash versions from the envoy/envoy-wasm fork for backwards compatibility. These versions using the older syntax will be removed as support for those versions of Istio & Gloo are ended.

Additional context
Latest Gloo 1.5.x release uses v0_2_1, Istio 1.7.2 uses v0_2_0.
@Sodman Sodman added the enhancement New feature or request label Oct 15, 2020
@Sodman Sodman self-assigned this Oct 15, 2020
@Sodman Sodman mentioned this issue Oct 26, 2020
Merged
8 tasks
@Sodman
Copy link
Member Author

Sodman commented Oct 28, 2020

Implemented by #212

@Sodman Sodman closed this as completed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sodman Sodman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sodman