Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Codegen check to CI #203

Closed
Sodman opened this issue Oct 21, 2020 · 1 comment
Closed

Add Codegen check to CI #203

Sodman opened this issue Oct 21, 2020 · 1 comment
Assignees
@Sodman
Labels
enhancement New feature or request

Comments

@Sodman
Copy link
Member

Sodman commented Oct 21, 2020

Is your feature request related to a problem? Please describe.
Several different make commands currently generate various areas of code, such as docs. Sometimes these don't all get run, and master can get out of sync with what files would be generated.

Describe the solution you'd like
We should have a quick automatic check on PRs which runs all of the code generation commands. If there's any difference, the check should fail and block the PR. The output should also explain how to run code check locally in order to pass the check on a new push.
@Sodman Sodman added the enhancement New feature or request label Oct 21, 2020
@Sodman Sodman self-assigned this Oct 21, 2020
@Sodman
Copy link
Member Author

Sodman commented Oct 26, 2020

Implemented by #202 && #207

@Sodman Sodman closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sodman Sodman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sodman