Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Istio 1.9 as a deployment target #239

Closed
Sodman opened this issue Feb 12, 2021 · 3 comments
Closed

Support Istio 1.9 as a deployment target #239

Sodman opened this issue Feb 12, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Sodman
Copy link
Member

Sodman commented Feb 12, 2021

Is your feature request related to a problem? Please describe.
Istio 1.9.0 was released this week. We should add support for this version in wasme.

Describe the solution you'd like
If the underlying wasm ABI has not changed in the Envoy version being used by istio proxy under the hood, then we just need to update the version check logic (this was the case when adding istio 1.8 support).

If the ABI has changed, we'll need to build a new example filter for istio in each of the 4 supported languages (cpp, assemblyScript, rust and tinyGo), so that wasme init will still work as expected for images targeting istio 1.9.

Describe alternatives you've considered
Users can use the --ignore-version-check flag to bypass the version check when deploying to Istio. Eg:
wasme deploy istio webassemblyhub.io/my-username/my-image:v1.0 --id my-filter --ignore-version-check

  • Note this will only work if the underlying ABI is compatible with the code in the filter.

Additional context
PR to add Istio 1.8 support is here for reference.

@Sodman Sodman added the enhancement New feature or request label Feb 12, 2021
@swartz-k
Copy link
Contributor

Hey, Can assign it to me? As We are running istio 1.9 on production env and looking forward to working with it with wasm.

@Sodman
Copy link
Member Author

Sodman commented Mar 23, 2021

Sure thing, appreciate the contribution! I believe it should be similar to the Istio 1.8.x PR mentioned above!

@swartz-k swartz-k mentioned this issue Mar 24, 2021
8 tasks
@Sodman
Copy link
Member Author

Sodman commented Mar 31, 2021

Implemented by #244

@Sodman Sodman closed this as completed Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants